Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor updates to website documentation #3946

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Minor updates to website documentation #3946

wants to merge 9 commits into from

Conversation

varodrig
Copy link
Contributor

  • Minor updates to Central Dashboard documentation

@google-oss-prow Google OSS Prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@varodrig varodrig marked this pull request as ready for review December 17, 2024 19:05
Arhell
Arhell reviewed Dec 28, 2024
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@varodrig
Copy link
Contributor Author

/assign @thesuperzapper

@varodrig
Copy link
Contributor Author

varodrig commented Jan 19, 2025 •
edited
Loading

@thesuperzapper @ederign any news on this PR?

thesuperzapper
thesuperzapper requested changes Jan 30, 2025
View reviewed changes
Copy link
Member

@thesuperzapper thesuperzapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

content/en/docs/components/central-dash/profiles.md Outdated Show resolved Hide resolved
content/en/docs/components/central-dash/profiles.md Outdated Show resolved Hide resolved
content/en/docs/components/central-dash/profiles.md Outdated Show resolved Hide resolved
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from thesuperzapper. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

varodrig and others added 2 commits January 31, 2025 18:11
@varodrig @thesuperzapper
Update content/en/docs/components/central-dash/profiles.md
e8a891f 
Co-authored-by: Mathew Wicks <[email protected]>
Signed-off-by: Valentina Rodriguez Sosa <[email protected]>
@varodrig @thesuperzapper
Update content/en/docs/components/central-dash/customize.md
be9b8fb 
Co-authored-by: Mathew Wicks <[email protected]>
Signed-off-by: Valentina Rodriguez Sosa <[email protected]>
terrytangyuan
terrytangyuan reviewed Feb 2, 2025
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about these changes. I feel like most of these linked concepts (namespace, configmap, CRD, etc.) should be prerequisites before reading or learning about Kubeflow

@varodrig
Copy link
Contributor Author

varodrig commented Feb 7, 2025

I am not sure about these changes. I feel like most of these linked concepts (namespace, configmap, CRD, etc.) should be prerequisites before reading or learning about Kubeflow

Do you think adding a link to the technical documentation will not help the reader? I agree that people should probably know already about it, but what if you do not remember a specific concept at that time.
Do you think we should assume that all our audience are knowledge about CRDs and other kubernetes concepts?

varodrig and others added 2 commits February 7, 2025 12:54
@varodrig @thesuperzapper
Update content/en/docs/components/central-dash/profiles.md
af11a4a 
Co-authored-by: Mathew Wicks <[email protected]>
Signed-off-by: Valentina Rodriguez Sosa <[email protected]>
@varodrig @thesuperzapper
Update content/en/docs/components/central-dash/profiles.md
bfb661e 
Co-authored-by: Mathew Wicks <[email protected]>
Signed-off-by: Valentina Rodriguez Sosa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan left review comments

@thesuperzapper thesuperzapper thesuperzapper requested changes

@Arhell Arhell Arhell left review comments

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

Assignees

@thesuperzapper thesuperzapper

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@varodrig @terrytangyuan @thesuperzapper @Arhell